Add Devise.available_router_name to support routing correctly with engines #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
my_engine
for this issue)my_engine
when going to a URL within that enginedevise_controller
, so 2FA gets applied.send(change_path)
is not enough as we will look forscope_two_factor_authentication_path
in the current app/engine. So this ends up meaningmy_engine.scope_two_factor_authentication_path
So steps...
Solution
Devise.available_router_name
instead, we getmain_app.scope_two_factor_authentication_path
(or whatever the router name is) and everything works from within the engineI couldn't get tests to run locally, otherwise, I'll try to get a test written. I've confirmed this works for my app, however, and I'm using my fork in production.