Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types for pagination handlers #1362

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

SeppahBaws
Copy link
Collaborator

This fixes a subtle bug that crept in with #1352, where the return types for loadNextPage and loadPreviousPage became Promise<QueryResult<_Data, _Input> | undefined> instead of the Promise<QueryResult<_Data, _Input>> as defined by the CursorHandlers type.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 08cdc95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-adapter-static Patch
houdini-react Patch
houdini Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 08cdc95
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/66fc4729aec2e200084cf587

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 08cdc95
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/66fc47295994f80008d24f65

@AlecAivazis AlecAivazis enabled auto-merge (squash) October 1, 2024 19:05
@AlecAivazis AlecAivazis merged commit 8d4226e into main Oct 1, 2024
15 checks passed
@AlecAivazis AlecAivazis deleted the pagination-handlers-return-type branch October 1, 2024 19:24
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants