DefaultCredentialsProvider moved from package 'org.htmlunit' into 'or…

…g.htmlunit.httpclient' (issue #764)
HtmlUnit · Apr 5, 2024 · c08361f · c08361f
1 parent f76eda3
commit c08361f
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 6 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,11 @@
 
     <body>
         <release version="4.1.0" date="April xx, 2024" description="Bugfixes">
+            <action type="update" dev="rbri">
+                INCOMPATIBLE CHANGE: DefaultCredentialsProvider moved from package 'org.htmlunit' into 'org.htmlunit.httpclient'.
+            </action>
+
+
             <action type="fix" dev="rbri">
                 Wrong script encoding was uses in some cases (regression in 4.0.0).
             </action>

diff --git a/src/main/java/org/htmlunit/WebClient.java b/src/main/java/org/htmlunit/WebClient.java
@@ -76,6 +76,7 @@
 import org.htmlunit.html.XHtmlPage;
 import org.htmlunit.html.parser.HTMLParser;
 import org.htmlunit.html.parser.HTMLParserListener;
+import org.htmlunit.httpclient.DefaultCredentialsProvider;
 import org.htmlunit.httpclient.HttpClientConverter;
 import org.htmlunit.javascript.AbstractJavaScriptEngine;
 import org.htmlunit.javascript.DefaultJavaScriptErrorListener;

diff --git a/.../htmlunit/DefaultCredentialsProvider.java → ...ttpclient/DefaultCredentialsProvider.java b/.../htmlunit/DefaultCredentialsProvider.java → ...ttpclient/DefaultCredentialsProvider.java
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.htmlunit;
+package org.htmlunit.httpclient;
 
 import java.io.IOException;
 import java.io.ObjectInputStream;
@@ -28,7 +28,6 @@
 import org.apache.http.auth.NTCredentials;
 import org.apache.http.auth.UsernamePasswordCredentials;
 import org.apache.http.client.CredentialsProvider;
-import org.htmlunit.httpclient.HtmlUnitUsernamePasswordCredentials;
 
 /**
  * Default HtmlUnit implementation of the <code>CredentialsProvider</code> interface. Provides

diff --git a/src/test/java/org/htmlunit/archunit/ArchitectureTest.java b/src/test/java/org/htmlunit/archunit/ArchitectureTest.java
@@ -349,7 +349,6 @@ public void check(final JavaMethod method, final ConditionEvents events) {
             .and().doNotHaveFullyQualifiedName("org.htmlunit.WebClient")
             .and().doNotHaveFullyQualifiedName("org.htmlunit.WebRequest")
             .and().doNotHaveFullyQualifiedName("org.htmlunit.util.Cookie")
-            .and().doNotHaveFullyQualifiedName("org.htmlunit.DefaultCredentialsProvider")
             .and().resideOutsideOfPackage("org.htmlunit.httpclient..")
         .should().dependOnClassesThat().resideInAnyPackage("org.apache.http..");
 

diff --git a/...unit/DefaultCredentialsProvider2Test.java → ...ient/DefaultCredentialsProvider2Test.java b/...unit/DefaultCredentialsProvider2Test.java → ...ient/DefaultCredentialsProvider2Test.java
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.htmlunit;
+package org.htmlunit.httpclient;
 
 import static org.junit.Assert.fail;
 
@@ -26,6 +26,8 @@
 import org.apache.logging.log4j.core.appender.WriterAppender;
 import org.apache.logging.log4j.core.config.Configurator;
 import org.apache.logging.log4j.core.layout.PatternLayout;
+import org.htmlunit.FailingHttpStatusCodeException;
+import org.htmlunit.WebServerTestCase;
 import org.htmlunit.html.HtmlPage;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.BrowserRunner.Alerts;

diff --git a/...unit/DefaultCredentialsProvider3Test.java → ...ient/DefaultCredentialsProvider3Test.java b/...unit/DefaultCredentialsProvider3Test.java → ...ient/DefaultCredentialsProvider3Test.java
@@ -12,7 +12,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.htmlunit;
+package org.htmlunit.httpclient;
 
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;

diff --git a/...lunit/DefaultCredentialsProviderTest.java → ...lient/DefaultCredentialsProviderTest.java b/...lunit/DefaultCredentialsProviderTest.java → ...lient/DefaultCredentialsProviderTest.java
@@ -12,11 +12,13 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.htmlunit;
+package org.htmlunit.httpclient;
 
 import org.apache.http.auth.AuthScope;
 import org.apache.http.auth.Credentials;
 import org.apache.http.impl.auth.BasicScheme;
+import org.htmlunit.HttpHeader;
+import org.htmlunit.SimpleWebTestCase;
 import org.htmlunit.html.HtmlPage;
 import org.htmlunit.junit.BrowserRunner;
 import org.junit.Test;