Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring - reduce the dependencies to HttpClient #764

Open
rbri opened this issue Apr 4, 2024 · 5 comments
Open

Refactoring - reduce the dependencies to HttpClient #764

rbri opened this issue Apr 4, 2024 · 5 comments
Assignees
@rbri

Comments

@rbri
Copy link
Member

rbri commented Apr 4, 2024 •
edited
Loading

To make it simpler to replace the HttpClient by a newer version or something completely different...

  • Cookie
  • HttpClientConverter - we have serveral direct dependencies on this; maybe we have to hide this behind WebConnection / HttpWebConnection
  • HttpClientConverter defines the constants for the Http Status Codes; maybe we have to maintain our own list of this codes
  • WebResponseData - we can add some builder methods for typical cases /200 / 404 ...
  • DefaultCredentialsProvider
@rbri rbri self-assigned this Apr 4, 2024
rbri added a commit that referenced this issue Apr 5, 2024
@rbri
DefaultCredentialsProvider moved from package 'org.htmlunit' into 'or…
c08361f 
…g.htmlunit.httpclient' (issue #764)
rbri added a commit that referenced this issue Apr 6, 2024
@rbri
Revert "DefaultCredentialsProvider moved from package 'org.htmlunit' …
e65c193 
…into 'org.htmlunit.httpclient' (issue #764)"

This reverts commit c08361f.
@rbri
Copy link
Member Author

rbri commented Apr 6, 2024

org.htmlunit.http.HttpStatus added

@rbri
Copy link
Member Author

rbri commented Apr 6, 2024

HttpUtils.formatDate(Date) / HttpUtils.parseDate(String)

@rbri
Copy link
Member Author

rbri commented Apr 7, 2024

HttpUtils.parseUrlQuery(String, Charset) / HttpUtils.toQueryFormFields(List, Charset)

@rbri
Copy link
Member Author

rbri commented Apr 8, 2024

branch 'towards5' created

rbri added a commit that referenced this issue Apr 8, 2024
@rbri
reworked cookie handling, HttpClientCookie introduced (issue #764)
4cf9821
@rbri
Copy link
Member Author

rbri commented Apr 8, 2024

HttpClientCookie added

@rbri rbri mentioned this issue Apr 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbri rbri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbri