chore: Fix project upload link (#1311)

HubSpot · Dec 18, 2024 · 26783ae · 26783ae
1 parent b20ec8b
commit 26783ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/lib/projects/buildAndDeploy.ts b/lib/projects/buildAndDeploy.ts
@@ -82,7 +82,7 @@ type PollTaskStatusFunctionConfig<T extends ProjectTask> = {
     accountId: number,
     taskName: string,
     taskId: number,
-    deployedBuildId: number
+    deployedBuildId: number | null
   ) => void;
 };
 
@@ -118,7 +118,7 @@ function makePollTaskStatusFunc<T extends ProjectTask>({
   ) {
     const displayId = deployedBuildId || taskId;
 
-    if (linkToHubSpot && !silenceLogs && deployedBuildId) {
+    if (linkToHubSpot && !silenceLogs) {
       logger.log(
         `\n${linkToHubSpot(accountId, taskName, taskId, deployedBuildId)}\n`
       );

diff --git a/lib/projects/upload.ts b/lib/projects/upload.ts
@@ -53,12 +53,14 @@ async function uploadProjectFiles(
       }),
     });
 
-    logger.debug(
-      i18n(`${i18nKey}.uploadProjectFiles.buildCreated`, {
-        buildId,
-        projectName,
-      })
-    );
+    if (buildId) {
+      logger.debug(
+        i18n(`${i18nKey}.uploadProjectFiles.buildCreated`, {
+          buildId,
+          projectName,
+        })
+      );
+    }
   } catch (err) {
     SpinniesManager.fail('upload', {
       text: i18n(`${i18nKey}.uploadProjectFiles.fail`, {