WIP: Get extension working in vscode.dev #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthmatic
commented
Nov 16, 2021
src/lib/validation.js
Outdated
| @@ -40,7 +39,7 @@ const isFileInWorkspace = (error) => { | |||
| filePath = filePath + '.module'; | |||
| } | |||
|
|
|||
| return fs.existsSync(path.resolve(dirToActiveFile, filePath)); | |||
| return vscode.workspace.fs.stat(path.resolve(dirToActiveFile, filePath)); | |||
There was a problem hiding this comment.
Roughly how to address fs, however this extension relies on cli-lib which uses fs directly
|
Just posting an update here on the progress: Most of the functionality is here to allow the extension to work in the web version of VS Code and removes its reliance on the HS CLI-LIB as well. However, because the extension operates in a WebWorker, requests that are made to the HS API fail because they do not have CORS enabled. Discussing a path forward internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new webpack config targeting browsers and fallbacks to handle most deps
Known issues:
@hubspot/cli-liband uses node'sfsmodule so we'll need to find an alternative method of loading a configFixes: #123