Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support code snippets from the BE #160

Closed
wants to merge 11 commits into from
Closed

Conversation

anthmatic
Copy link
Contributor

I had originally planned to fix the extra empty file that was generate in #148 but I realized that a while back we added a codeSnippet property to the hubldoc endpoint. Unfortunately, as you can see here https://github.com/HubSpot/hubspot-cms-vscode/compare/ap/support-codeSnippets?expand=1#diff-1942d5c2aca105453d76b423494f061cfe94a22144fcfe87eb80aedc6b7fb67fR1 a lot of the snippets are incorrect.

The main issue is that snippets like

{% gallery ${1:slides} ${2:loop_slides} ${3:num_seconds} ${4:show_pagination} ${5:sizing} ${6:auto_advance} ${7:transition} ${8:caption_position} ${9:display_mode} ${10:lightboxRows} %}"

are missing the argument syntax, so ${1:slides} should look more like slides="${1:slides}"

I'll work on getting those updated before merging this in.

@anthmatic anthmatic marked this pull request as ready for review January 10, 2023 19:15
@anthmatic anthmatic requested a review from a team January 10, 2023 19:15
Copy link
Contributor

@jsines jsines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TanyaScales added a commit that referenced this pull request Jul 27, 2023
@TanyaScales
Copy link
Member

Closing in favor of #243

@TanyaScales TanyaScales deleted the ap/support-codeSnippets branch July 27, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants