Add config option to fail on unknown enum values #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jhaber! Thanks for this library, it is very useful :)
We have recently faced an issue related to serialization of unknown enum values coming from a newer version of a proto schema. The issue is the same as described in #58. It would be great to have a way to configure the serializer to fail instead of producing values like
UNKNOWN_ENUM_VALUE_TestType_2. For example, fail-fast behavior is desirable to avoid storing JSONs with such values in a database.This PR adds a configurable
UnknownEnumSerializationStrategyinterface that handles unknown enum value descriptors. The default behavior is to serialize as-is. New additional behavior is to fail withIllegalArgumentException. The strategy is configurable viaProtobufJacksonConfig.Could you please take a look at this PR and let me know if you think this is a reasonable suggestion?
Thanks a lot in advance!