Explicitly defer node when attempting deferring an aliased modification in an imported macro function #1120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly fail by creating a deferred node when attempting to defer modification of an alias outside of the context of an import.
This is a niche situation that we'd rather explicitly fail on than have incorrect logic. Handling this correctly is complex and likely not worth it.
Example:
We don't know how that
shared
should be deferred soshared.settings
ends up getting resolved as{}
. This is what the output looks like before this PR:I tried actually supporting it, but since we can't reconstruct alias maps with macro functions inside of them outside of an import tag anyway, I decided to just short circuit the failure rather than adding a bunch of extra logic which ultimately flags the same failure condition. Here's that branch: ea4a7ac