Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade basepom #1143

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Upgrade basepom #1143

merged 3 commits into from
Jan 9, 2024

Conversation

jaredstehler
Copy link
Contributor

@jaredstehler jaredstehler commented Jan 8, 2024 •
edited
Loading

  • upgrade basepom (25 -> 56)
  • moves checkstyle config out of src, to omit from artifact
  • creates filters for new spotbugs violations reference
  • fixes line endings in source file
  • removes pin forcing build on jdk17

@jaredstehler jaredstehler requested a review from boulter January 8, 2024 20:34
boulter
boulter approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@boulter boulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome home.

@jaredstehler jaredstehler merged commit 8a0257a into master Jan 9, 2024
4 checks passed
@jaredstehler jaredstehler deleted the js/upgrade-basepom branch January 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulter boulter boulter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredstehler @boulter