find first valid deferred words #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
reviewed
Apr 19, 2024
| @@ -413,10 +418,19 @@ private static CallStack acquireMacroStack() { | |||
| .orElse(null); | |||
| } | |||
|
|
|||
| private static String getFirstNonEmptyToken(List<String> strings) { | |||
| return Strings.isNullOrEmpty(strings.get(0)) ? strings.get(1) : strings.get(0); | |||
There was a problem hiding this comment.
I think that you need to split more if you're going to take the part after a . because you could have .bar.foobar and you want bar not bar.foobar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We end up with a lot blank deferred words when they are attributes of array values.
For example,
{{ deferred.results[0].attribute }}will return the used tokensdeferredand.attribute..attributeis treated a value ofattributewith a base of (blank) because it splits on periods. This cleans up the general case, but the evaluated eager expressions could also be improved so we don't end up with words with leading periods.