Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Jakarta EL 4 compatible version of JUEL #915

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dmaidaniuk
Copy link

PR for issue #809

Please note, that here used a fork of JUEL library upgraded to Jakarta EL 4:

https://github.com/UkrSoftTech/juel/tree/jakarta-el-4

@dmaidaniuk
Copy link
Author

The original repo of JUEL https://github.com/beckchr/juel is not maintained since 2018. So, either the forked repo should be deployed to the Sonatype repository with a changed group id, or sources of JUEL should be included in the Jinjava library.

@dmaidaniuk
Copy link
Author

@jasmith-hs please take a look.

@jasmith-hs
Copy link
Contributor

We will likely lean more towards including the sources into the Jinjava library like in #810
Since the original repo isn't maintained. It will be simpler to fix any bugs this way/upgrade to EL 5 if we desire that.

We could also maintain our own fork of JUEL cc @mattcoley @boulter

@dmaidaniuk
Copy link
Author

@jasmith-hs I can transfer ownership of https://github.com/UkrSoftTech/juel/ repository to HubSpot organization. Also, in that fork I made the migration to EL 5 on another branch https://github.com/UkrSoftTech/juel/tree/jakarta-el-5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants