Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the code compliant for the jackson upgrade #133

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

suruuK
Copy link

@suruuK suruuK commented Mar 29, 2024

Description

This will be a noop for the most part, had to make one small code change but that was mostly copying the behaviour of the older library code. https://bitbucket.org/snakeyaml/snakeyaml/src/e91772b1bc0bc67e4fb60e4c19a1a7ba0a180896/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java#lines-51

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@jhaber jhaber force-pushed the upgrade-snakeyaml branch from 3665f64 to c020454 Compare July 16, 2024 16:18
skudikala and others added 4 commits October 21, 2024 17:33
code should still compile with older versions, we can bump these in parent pom as we canary
@suruuK suruuK changed the title upgrade jackson & snakeyaml make the code compliant for the jackson upgrade Dec 6, 2024
@suruuK suruuK merged commit 0b4510d into 5.12.2-hubspot Dec 6, 2024
2 of 8 checks passed
@suruuK suruuK deleted the upgrade-snakeyaml branch December 6, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant