Use write-build-env-var utility to move off RC file #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maksung228 Would you be someone to review and merge this? |
|
I just realised I had actually PR'd cleaning up the RC file different a month ago 🤦 #12 @maksung228 I'll let you decide if the environment variables actually need to be persisted through the build or if they are only needed in the current build step. Then you can choose which PR to close and which to merge. This PR will persist the env variables throughout all the build steps. The other PR just does not persist them at all anymore outside of the scope of the script using them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We're moving off of using the build command RC file for persisting env variables. Replacing the usage with a utility script you can use that will persist env variable changes to any env variables that have beed defined as part of the build config (which is why I had to define the two extra env variables initialised with empty strings in the .blazar.yaml)