Check for valid name before reformatting bracket notation to use dots #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2024
jsines
previously approved these changes
May 9, 2024
TanyaScales
previously approved these changes
May 9, 2024
j-malt
dismissed stale reviews from TanyaScales and jsines
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70 (and maybe #68) by checking that the bracketed name can be converted to a dot notation before doing it. Otherwise just uses regular brackets. The regex here is
/^[a-zA-Z_$][0-9a-zA-Z_$]*$/which roughly should match any valid Javascript variable, which should cover valid HubL variable names as well. See updated snapshot for updated behaviour.