Skip to content

Commit

Permalink
Merge pull request #344 from HubSpot/deprecate-old-methods
Browse files Browse the repository at this point in the history
Deprecate old methods
  • Loading branch information
jaredstehler authored May 15, 2024
2 parents 7ebb60d + c13af67 commit f2e8546
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ An asychronous HTTP client wrapping Slack's [RPC-style web api](https://api.slac

**NOTICE:**

The original web API method for uploading files to Slack, `files.upload`, is being sunset on March 11, 2025. [See details](https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay)

On October 18th 2019, Slack will stop supporting the `replies` thread on a `Message` returned from the [`conversations.replies` endpoint](https://api.slack.com/methods/conversations.replies) as well as any places that use `LiteMessage`.

Due to this, we are deprecating `getReplies()` on [`LiteMessage`](https://github.com/HubSpot/slack-client/blob/master/slack-base/src/main/java/com/hubspot/slack/client/models/LiteMessageIF.java)
Expand Down Expand Up @@ -79,6 +81,8 @@ We currently support:
- dialog.open
#### files
- files.upload
- files.getUploadURLExternal
- files.completeUploadExternal
- files.sharedPublicURL
#### groups
- groups.kick (kickUserFromGroup)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@
import com.hubspot.slack.client.models.response.dnd.DndSnoozeResponse;
import com.hubspot.slack.client.models.response.emoji.EmojiListResponse;
import com.hubspot.slack.client.models.response.files.CompleteUploadExternalResponse;
import com.hubspot.slack.client.models.response.files.CompleteUploadExternalResponseIF;
import com.hubspot.slack.client.models.response.files.FilesSharedPublicUrlResponse;
import com.hubspot.slack.client.models.response.files.FilesUploadResponse;
import com.hubspot.slack.client.models.response.files.GetUploadUrlExternalResponse;
Expand Down Expand Up @@ -392,9 +391,16 @@ CompletableFuture<Result<AddReactionResponse, SlackError>> addReaction(
CompletableFuture<Result<TeamInfoResponse, SlackError>> getTeamInfo();

// files
/**
* This method is being sunset on March 11, 2025
* @deprecated use {@link #getUploadURLExternal(GetUploadUrlExternalParams)} and {@link #completeUploadExternal(CompleteUploadExternalParams)}
* @see <a href="https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay">Sunset details</a>
*/
@Deprecated
CompletableFuture<Result<FilesUploadResponse, SlackError>> uploadFile(
FilesUploadParams params
);

CompletableFuture<Result<GetUploadUrlExternalResponse, SlackError>> getUploadURLExternal(
GetUploadUrlExternalParams params
);
Expand Down

0 comments on commit f2e8546

Please sign in to comment.