Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file info method to retrieve all file info #359

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

opaliukh
Copy link
Contributor

@opaliukh opaliukh commented Oct 11, 2024

Add file info method to retrieve all file info

Copy link

@kubayof kubayof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ykaliukh ykaliukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Maybe it is better to rename models because we only get 1 file. FilesInfoParamsIF -> FileInfoParamsIF

@kubayof
Copy link

kubayof commented Oct 13, 2024

LGTM! Maybe it is better to rename models because we only get 1 file. FilesInfoParamsIF -> FileInfoParamsIF

I thought the names are derived from the api method name, from this repository: users.info -> UsersInfoParams - this returns 1 user as well

@opaliukh opaliukh merged commit 1cb0cfb into master Oct 14, 2024
2 checks passed
@opaliukh opaliukh deleted the add-file-info-method branch October 14, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants