Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init on addon register #260

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Init on addon register #260

merged 2 commits into from
Dec 18, 2023

Conversation

keianhzo
Copy link
Contributor

We were not initializing on add-on register, only on scene open. This PR ensures that the scene debugger is always initialized after addon registreation.

Copy link
Contributor

@Exairnous Exairnous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Not sure why the tests aren't passing here, but they're fine when I ran them locally.

Avoid operator call when registering
@keianhzo keianhzo force-pushed the init-on-addon-register branch from 5806c68 to 3534bb0 Compare December 18, 2023 10:11
@keianhzo
Copy link
Contributor Author

Not sure why but it seemed to be the operator call while registering, maybe the operator was not yet fully initialized.

@keianhzo keianhzo merged commit 5f43404 into master Dec 18, 2023
6 checks passed
@keianhzo keianhzo added this to the 1.3.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants