Fix things related to scene-grababbles #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d body components, and add missing gltf_yup checks to physics shape/rigid body import.
Exairnous
added a commit
that referenced
this pull request
Nov 26, 2024
Scene grabbables support was reverted in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit removes the scene grabbables and physics support from the main Blender add-on to maintain compatibility with the current Hubs Client. A corresponding commit to the behavior graphs Blender add-on adds support for scene grabbables/physics back into the behavior graphs Blender add-on so that the functionality isn't lost and can be used there. Reverts "Merge pull request #285 from MozillaReality/fix-import-error-reporting" This reverts commit 7eb5656, reversing changes made to 87074ec. Reverts "Merge pull request #282 from MozillaReality/scene-grabbables" This reverts commit 87074ec, reversing changes made to 3712349.
Exairnous
added a commit
that referenced
this pull request
Nov 26, 2024
Scene grabbables support was reverted in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit removes the scene grabbables and physics support from the main Blender add-on to maintain compatibility with the current Hubs Client. A corresponding commit to the behavior graphs Blender add-on adds support for scene grabbables/physics back into the behavior graphs Blender add-on so that the functionality isn't lost and can be used there. Revert "Merge pull request #285 from MozillaReality/fix-import-error-reporting" This reverts commit 7eb5656, reversing changes made to 87074ec. Revert "Merge pull request #282 from MozillaReality/scene-grabbables" This reverts commit 87074ec, reversing changes made to 3712349.
Exairnous
added a commit
that referenced
this pull request
Nov 26, 2024
Scene grabbables support was reverted in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit removes the scene grabbables and physics support from the main Blender add-on to maintain compatibility with the current Hubs Client. A corresponding commit to the behavior graphs Blender add-on adds support for scene grabbables/physics back into the behavior graphs Blender add-on so that the functionality isn't lost and can be used there. Reverts "Merge pull request #285 from MozillaReality/fix-import-error-reporting" This reverts commit 7eb5656, reversing changes made to 87074ec. Reverts "Merge pull request #282 from MozillaReality/scene-grabbables" This reverts commit 87074ec, reversing changes made to 3712349.
Exairnous
added a commit
that referenced
this pull request
Nov 26, 2024
Scene grabbables support was reverted (Hubs-Foundation/hubs#6515) in the Hubs client due to bugs and is now only present for the Hubs Client's addons branch and its behavior graphs add-on. This commit removes the scene grabbables and physics support from the main Blender add-on to maintain compatibility with the current Hubs Client. A corresponding commit to the behavior graphs Blender add-on adds support for scene grabbables/physics back into the behavior graphs Blender add-on so that the functionality isn't lost and can be used there. Reverts "Merge pull request #285 from MozillaReality/fix-import-error-reporting" This reverts commit 7eb5656, reversing changes made to 87074ec. Reverts "Merge pull request #282 from MozillaReality/scene-grabbables" This reverts commit 87074ec, reversing changes made to 3712349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix import error reporting, simplify the import of physics shape/rigid body components, and add missing gltf_yup checks to physics shape/rigid body import.