eslint disable react unknown property for props known

Hubs-Foundation · Jun 5, 2023 · e4bcf93 · e4bcf93
1 parent 30452ff
commit e4bcf93
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 0 deletions.
diff --git a/src/gltf-component-mappings.js b/src/gltf-component-mappings.js
@@ -132,6 +132,7 @@ import { createElementEntity } from "./utils/jsx-entity";
 import { setInitialNetworkedData } from "./utils/assign-network-ids";
 /** @jsx createElementEntity */ createElementEntity;
 
+// eslint-disable-next-line react/no-unknown-property
 AFRAME.GLTFModelPlus.registerComponent("media-frame", "media-frame", (el, _componentName, componentData) => {
   const eid = renderAsEntity(APP.world, <entity mediaFrame={componentData} />);
 

diff --git a/src/prefabs/camera-tool.js b/src/prefabs/camera-tool.js
@@ -1,4 +1,5 @@
 /* eslint-disable react/prop-types */
+/* eslint-disable react/no-unknown-property */
 /** @jsx createElementEntity */
 import cameraModelSrc from "../assets/camera_tool.glb";
 import { Layers } from "../camera-layers";

diff --git a/src/prefabs/error-object.js b/src/prefabs/error-object.js
@@ -1,3 +1,4 @@
+/* eslint-disable react/no-unknown-property */
 /** @jsx createElementEntity */
 import { createElementEntity } from "../utils/jsx-entity";
 import { ProjectionMode } from "../utils/projection-mode";

diff --git a/src/prefabs/loading-object.js b/src/prefabs/loading-object.js
@@ -1,3 +1,4 @@
+/* eslint-disable react/no-unknown-property */
 /** @jsx createElementEntity */
 import { BoxGeometry, Mesh, MeshBasicMaterial } from "three";
 import { createElementEntity } from "../utils/jsx-entity";

diff --git a/src/react-components/chat-message.js b/src/react-components/chat-message.js
@@ -50,6 +50,8 @@ function renderChatMessage(body, from, allowEmojiRender) {
 
   const EntryDom = ({ callback }) => (
     <div
+    // callback is passed in here as part of React 18 createRoot method.
+    // eslint-disable-next-line react/no-unknown-property
       callback={callback}
       className={classNames({
         [styles.presenceLogEntry]: !isEmoji,
@@ -61,6 +63,11 @@ function renderChatMessage(body, from, allowEmojiRender) {
     </div>
   );
 
+  EntryDom.propTypes = {
+    callback: PropTypes.func
+  };
+
+
   return new Promise((resolve, reject) => {
     const root = createRoot(el);
     root.render(