Remove should clauses from lira queries
#163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanehsan
approved these changes
May 15, 2019
They don't do anything, they just look like they do. " If the bool query is in a query context and has a must or filter clause then a document will match the bool query even if none of the should queries match." https://www.elastic.co/guide/en/elasticsearch/reference/6.3/query-dsl-bool-query.html
samanehsan
force-pushed
the
mk-remove-should
branch
2 times, most recently
from
d7ab1ca
to
7d9b69b
Compare
|
Thanks for the PR Marcus! I think what we should add to the query is to match on |
rhiananthony
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't do anything, they just look like they do. "If the bool query
is in a query context and has a must or filter clause then a document
will match the bool query even if none of the should queries match."
https://www.elastic.co/guide/en/elasticsearch/reference/6.3/query-dsl-bool-query.html