Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1511: Support data batch context for autorefinement #232

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

matt-bernstein
Copy link
Contributor

@matt-bernstein matt-bernstein commented Oct 18, 2024

fix /improve-prompt request to not require a jobid, as a job has not yet been created

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.70%. Comparing base (b0f1e1d) to head (a6dbc10).

Files with missing lines Patch % Lines
adala/skills/collection/prompt_improvement.py 57.14% 3 Missing ⚠️
adala/agents/base.py 0.00% 2 Missing ⚠️
adala/skills/_base.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files          47       47           
  Lines        2350     2350           
=======================================
  Hits         1544     1544           
  Misses        806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-bernstein matt-bernstein changed the title Fb dia 1511 feat: DIA-1511: Support data batch context for autorefinement Oct 18, 2024
@robot-ci-heartex robot-ci-heartex marked this pull request as draft October 18, 2024 11:05
@niklub
Copy link
Contributor

niklub commented Oct 21, 2024

Does this PR introduce any functional changes or is it only about reformatting and renaming?

@matt-bernstein
Copy link
Contributor Author

the only functional change is this

fix /improve-prompt request to not require a jobid, as a job has not yet been created

which I assume was a bug, unless it's to support some future pathway what I didn't know about

@pakelley
Copy link
Contributor

Approved as far as these changes being fine, but to be clear: do we just not actually need any substantive changes (aside from not requiring the job_id) to support this?

@matt-bernstein
Copy link
Contributor Author

Approved as far as these changes being fine, but to be clear: do we just not actually need any substantive changes (aside from not requiring the job_id) to support this?

That's right. It's a bit hard to follow all the plumbing, but the PromptImprovementSkill is currently implemented as an AnalysisSkill: DataFrame -> Record, where all other inputs go in the static instructions field and the GT data batch is the DataFrame. This needs some rethinking in the future if we want the ability to input multiple kinds of example data, such as with and without GT, or positive (correct) vs negative (incorrect) examples. Especially since we don't actually want anything implemented in the AnalysisSkill (just batching, afaik), But that's what we have for now.

@niklub niklub marked this pull request as ready for review October 25, 2024 08:26
@niklub niklub merged commit c31b3b9 into master Oct 25, 2024
17 of 19 checks passed
@niklub niklub deleted the fb-dia-1511 branch October 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants