-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DIA-1511: Support data batch context for autorefinement #232
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 65.70% 65.70%
=======================================
Files 47 47
Lines 2350 2350
=======================================
Hits 1544 1544
Misses 806 806 ☔ View full report in Codecov by Sentry. |
Does this PR introduce any functional changes or is it only about reformatting and renaming? |
the only functional change is this
which I assume was a bug, unless it's to support some future pathway what I didn't know about |
Approved as far as these changes being fine, but to be clear: do we just not actually need any substantive changes (aside from not requiring the job_id) to support this? |
That's right. It's a bit hard to follow all the plumbing, but the PromptImprovementSkill is currently implemented as an AnalysisSkill: DataFrame -> Record, where all other inputs go in the static |
fix /improve-prompt request to not require a jobid, as a job has not yet been created