Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1556: Not getting predictions for all tasks #240

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

hakan458
Copy link
Contributor

@hakan458 hakan458 commented Oct 29, 2024

acks='all' ensures that all replicas have written the message that is produced

group_id for consumers is to allow multiple consumers to consume from the same topic. In this case we have a 1-to-1 relationship and each group_id should be unique in order to properly track the offset for each topic

manual offset committing in the consumer seems to have solved the issue. 4 in a row runs with 10k/10k outputs.

We still need the time.sleep(0.1) in the submit_batch endpoint, without it we still hit the same offset issue on the consumer side... unclear why exactly.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (0c667eb) to head (7695136).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   65.89%   65.70%   -0.19%     
==========================================
  Files          47       47              
  Lines        2372     2391      +19     
==========================================
+ Hits         1563     1571       +8     
- Misses        809      820      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niklub niklub self-requested a review October 30, 2024 11:59
Copy link
Contributor

@niklub niklub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see these findings! approved, but please clarify the meaning of each arguments by adding the comments in the code

@hakan458 hakan458 merged commit 3665a80 into master Oct 30, 2024
10 of 11 checks passed
@hakan458 hakan458 deleted the fb-dia-1556 branch October 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants