Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-1534: JSON values interpreted as format spec #243

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

matt-bernstein
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (2bf8169) to head (c22aa5c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
adala/utils/parse.py 69.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   65.67%   65.71%   +0.04%     
==========================================
  Files          47       47              
  Lines        2392     2424      +32     
==========================================
+ Hits         1571     1593      +22     
- Misses        821      831      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot-ci-heartex robot-ci-heartex marked this pull request as draft November 2, 2024 06:06
@niklub niklub self-requested a review November 4, 2024 15:49
@matt-bernstein matt-bernstein marked this pull request as ready for review November 4, 2024 15:53
@matt-bernstein matt-bernstein merged commit 882ca68 into master Nov 4, 2024
17 of 19 checks passed
@matt-bernstein matt-bernstein deleted the fb-dia-1534-format-spec branch November 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants