fix: DIA-1584: Use send_and_wait + batches for output topic #245
+60
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakelley
reviewed
Nov 4, 2024
pakelley
approved these changes
Nov 4, 2024
matt-bernstein
approved these changes
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 65.71% 65.67% -0.05%
==========================================
Files 47 47
Lines 2424 2421 -3
==========================================
- Hits 1593 1590 -3
Misses 831 831 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back to using send_and_wait, which while using before we never lost a message in this stage.
However, we switched to send for speed purposes. To mitigate this, we are now sending batches of records to the output topic, instead of calling send_and_wait once per record. Even if we have the small delay while awaiting the result, that will now happen once per batch (e.g. 50 records) instead of once per record, greatly reducing the time it takes.