-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DIA-1783: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Loading status checks…
bmartel
reviewed
Jan 9, 2025
bmartel
reviewed
Jan 9, 2025
bmartel
reviewed
Jan 9, 2025
bmartel
reviewed
Jan 9, 2025
bmartel
reviewed
Jan 9, 2025
bmartel
reviewed
Jan 9, 2025
Loading status checks…
Co-authored-by: bmartel <brandonmartel@gmail.com>
nick-skriabin
changed the title
[FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE
feat: DIA-1783: [FE] Prep work - Tailwind + shadcn cross integration in LSO + LSE
Jan 21, 2025
There are lint failures and the branch looks like it needs to merge develop again. |
bmartel
reviewed
Jan 21, 2025
bmartel
reviewed
Jan 21, 2025
bmartel
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the FE changes, based on the minor questions/observations.
yyassi-heartex
approved these changes
Jan 22, 2025
hlomzik
reviewed
Jan 22, 2025
hlomzik
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step for Tailwind and Shadcn adoption. It doesn't bring any visual changes at the moment and acts as a foundations for the future work.