-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SM2Util 支持通过密钥对和证书的字符串形式加载其对象 #82
feat: SM2Util 支持通过密钥对和证书的字符串形式加载其对象 #82
Conversation
首先 我们启用了DCO检测,请依据DCO检测的提示修改提交的信息。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comments.
src/test/java/SM2UtilTest.java
Outdated
@Test | ||
public void testLoadPrivFromString() throws Exception { | ||
InputStream in = SM2UtilTest.class.getResourceAsStream("testdata.yml"); | ||
Map<String, Map<String, Object>> configMap = ConfigLoader.loadConfig(in); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
完全可以弄一个全局变量吧?没必要copy paste yourself
Signed-off-by: photowey <[email protected]>
4cd7428
to
a757e30
Compare
Signed-off-by: photowey <[email protected]>
03ed3bd
to
8cbae2c
Compare
@ryjones or @davidkhala , could you please help check our CI. It seems just DCO is running. |
it was disabled by github as it has not run in over 90 days. I've re-enabled it. @SamYuan1990 it should run on the next push to the PR |
thanks @ryjones , @photowey , could you please make a dummy commit so that we can trigger CI? |
OK |
Signed-off-by: photowey <[email protected]>
d33dd56
to
d418970
Compare
Signed-off-by: photowey <[email protected]>
Signed-off-by: photowey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update PR description and merge. |
@photowey thanks for your contribute. |
SM2Util#loadPrivFromString
;SM2Util#loadPublicFromString
;SM2Util#loadX509CertificateFromString
;