Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue053/cards refactor sonar #68

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Issue053/cards refactor sonar #68

merged 5 commits into from
Feb 11, 2024

Conversation

wisskirchenj
Copy link
Collaborator

No description provided.

@wisskirchenj
add card mapper test
6b68ab6
@wisskirchenj
Merge branch 'main' into issue053/sonar-card-tests
ae309d0
@wisskirchenj
add card service test,
5488b68 
fix delete and some refactorings
@wisskirchenj
refactor entities to records implementing Card interface
78f5446 
also rename volume to allow for purge to work again, add ValidatorUnitTests
@wisskirchenj
fix update for different types &
62a22b8 
add controller IT and validation test
@wisskirchenj wisskirchenj mentioned this pull request Feb 11, 2024
Closed
alfabravo2013
alfabravo2013 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@alfabravo2013 alfabravo2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we discussed all the changes, everything is fine.

docker/arch/compose_amd.yaml Show resolved Hide resolved
server/src/main/java/org/hyperskill/community/flashcards/card/CardService.java Show resolved Hide resolved
server/src/main/java/org/hyperskill/community/flashcards/card/ExampleDataInitializer.java Show resolved Hide resolved
server/src/main/java/org/hyperskill/community/flashcards/card/model/Card.java Show resolved Hide resolved
server/src/main/java/org/hyperskill/community/flashcards/card/model/QuestionAndAnswer.java Show resolved Hide resolved
@wisskirchenj wisskirchenj merged commit 958f058 into main Feb 11, 2024
1 check passed
@wisskirchenj wisskirchenj deleted the issue053/cards-refactor-sonar branch February 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfabravo2013 alfabravo2013 alfabravo2013 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wisskirchenj @alfabravo2013