Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor templates refactor #75

Merged
merged 1 commit into from
Feb 18, 2024
Merged

minor templates refactor #75

merged 1 commit into from
Feb 18, 2024

Conversation

codeofcarbon
Copy link
Collaborator

refactor mainly touches expanded tags, which I removed where those weren't needed, pl[us some other minor stuff like gathering colors in one place. No features improvements here 😺

@wisskirchenj
Copy link
Collaborator

Yepp - better!
Thanks for adding all those semicolons after the const lambdas - funny, that I seem to keep forgetting those :-/
Actually, this finding showed me, that we don't use the linter yet... otherwise it would have told ...

@wisskirchenj
Copy link
Collaborator

Hmm - did you see in discord-server:
Linting throws errors for v-text / v-html use in components:
The rule is: https://eslint.vuejs.org/rules/no-v-text-v-html-on-component
And here is some (convincing IMO) discussion, why it makes sense: vuejs/eslint-plugin-vue#1724

So I guess we should not use v-text and v-html... But I would not mind merging this anyway.. What do you think?

@codeofcarbon codeofcarbon merged commit 86fc9d4 into main Feb 18, 2024
1 check passed
@codeofcarbon codeofcarbon deleted the minor-templates-refactor branch February 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants