Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDS: Update import to align with upstream changes #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sunnyhaibin
Copy link

@sunnyhaibin sunnyhaibin commented Jan 16, 2025

Description

  • uds.py has been migrated from panda to opendbc, which means this script will currently break when running on branches using the latest upstream code.
  • This change updates the import paths to maintain compatibility with the updated upstream structure. It also removes the fallback mechanism for handling different installation environments, simplifying the script's dependencies.
  • Ensures that the script works seamlessly with the latest code and avoids potential breakages when used alongside future upstream changes.

Upstream PRs

@sunnyhaibin sunnyhaibin changed the title update uds import UDS: Update import to align with upstream changes Jan 16, 2025
@calvinpark
Copy link
Contributor

calvinpark commented Jan 16, 2025

Please add the old imports back. One of the more popular fork/branch is anbuck's TSK port onto an old FP version, which uses the old import path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants