Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSG-100 Merge all Generators into one and use only one script #27

Merged
merged 10 commits into from
Aug 26, 2024

Conversation

xkmato
Copy link
Contributor

@xkmato xkmato commented Aug 7, 2024

This subtask merges all generators into one command. Since these are all reading the same file and only changing how the content of the file is output. It makes sense to use only one command and give the user options on whether they want to generate all the artifacts or skip some.

The command is who_l3_smart_tools/cli/generate.py -i tests/data/l2/test_dd.xlsx -o data/ if you want to skip any of the items you can add a flag like --skip-concepts or --skip-models or ----skip-questionnaire

@xkmato xkmato requested review from ibacher and pmanko August 7, 2024 13:41
Copy link
Collaborator

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things, but basically LGTM

who_l3_smart_tools/cli/generate.py Outdated Show resolved Hide resolved
who_l3_smart_tools/core/data_dictionary/l2.py Outdated Show resolved Hide resolved
who_l3_smart_tools/cli/data_dictionary.py Outdated Show resolved Hide resolved
who_l3_smart_tools/core/l2/data_dictionary.py Outdated Show resolved Hide resolved
@xkmato xkmato merged commit 2bd0440 into main Aug 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants