Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding date by default. #212

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Adding date by default. #212

merged 2 commits into from
Oct 5, 2023

Conversation

jwbos
Copy link
Collaborator

@jwbos jwbos commented Oct 5, 2023

No description provided.

@jwbos jwbos requested a review from kmccurley October 5, 2023 11:37
@jwbos jwbos self-assigned this Oct 5, 2023
@jwbos jwbos mentioned this pull request Oct 5, 2023
Closed
kmccurley
kmccurley approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@kmccurley kmccurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skeptical that we need another package dependency for this. We could just put \today into the footer and let the author use a package to modify how that is formatted if they want to.

@jwbos
Copy link
Collaborator Author

jwbos commented Oct 5, 2023

I'm skeptical that we need another package dependency for this. We could just put \today into the footer and let the author use a package to modify how that is formatted if they want to.

Good point, I fixed this and added the option to omit displaying the date when an empty string is passed.

@jwbos jwbos merged commit 17f6cbe into main Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmccurley kmccurley kmccurley approved these changes

Assignees

@jwbos jwbos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwbos @kmccurley @joppebos