Removed the region from tagging and search private api construction

[ujjwal-ibm]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[ujjwal-ibm]

@luiof @mkrudele @hkantare

[argeiger]

Tested with visibility set to "private" in us-east

2024-12-05T10:12:49.022-0500 [INFO]  provider.terraform-provider-ibm: 2024/12/05 10:12:49 [Debug] Sending HTTP request message...: timestamp=2024-12-05T10:12:49.022-0500
2024-12-05T10:12:49.022-0500 [INFO]  provider.terraform-provider-ibm: 2024/12/05 10:12:49 [DEBUG] GET https://tags.private.global-search-tagging.cloud.ibm.com/v3/tags?tag_type=access: timestamp=2024-12-05T10:12:49.022-0500
2024-12-05T10:12:49.810-0500 [INFO]  provider.terraform-provider-ibm: 2024/12/05 10:12:49 [Debug] Considering retry attempt; status_code=200, method=GET, url=https://tags.private.global-search-tagging.cloud.ibm.com/v3/tags?tag_type=access, error=nil: timestamp=2024-12-05T10:12:49.810-0500
2024-12-05T10:12:49.810-0500 [INFO]  provider.terraform-provider-ibm: 2024/12/05 10:12:49 [Debug] No retry for status code: 200: timestamp=2024-12-05T10:12:49.810-0500
2024-12-05T10:12:49.810-0500 [INFO]  provider.terraform-provider-ibm: 2024/12/05 10:12:49 [Debug] Received HTTP response message, status code 200: timestamp=2024-12-05T10:12:49.810-0500
2024-12-05T10:12:49.811-0500 [INFO]  provider.terraform-provider-ibm: 2024/12/05 10:12:49 [Debug] Response:
HTTP/2.0 200 OK

Terraform will perform the following actions:

  # ibm_is_security_group.example will be created
  + resource "ibm_is_security_group" "example" {
      + access_tags             = (known after apply)
      + crn                     = (known after apply)
      + id                      = (known after apply)
      + name                    = "example-security-group"
      + resource_controller_url = (known after apply)
      + resource_crn            = (known after apply)
      + resource_group          = (known after apply)
      + resource_group_name     = (known after apply)
      + resource_name           = (known after apply)
      + rules                   = (known after apply)
      + tags                    = [
          + "sg",
          + "test",
        ]
      + vpc                     = "r014-b844255a-2c4e-4f12-817d-4b4f19eddda3"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

[luiof]

I approved the changes since the global private endpoint is valid, however the global private endpoints are reachable in a VPC with a VPE GW attached only; if we try the code from our local machine it will not work. Could we add a reference to the IBM doc and a comment about this? Just to avoid confusion from a customer point of view.
Thank you

[ocofaigh]

As mention in internal discussions, this won't work for a region like eu-east (which isn't CSE proxy enabled) when running in Schematics or local (unless you use a custom schematics agent with VPE set up).
The suggestion from provider team was:

May be we need to map the region if its us-south/us-east use us-south regional private endpoint
the fix shd be that way else fall back to us-south