Add upper/lower presentation format for am/pm in fromMillis #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Woodgate <[email protected]>
alexwoodgate
force-pushed
the
upperAMPM
branch
from
531774b
to
e55d930
Compare
|
@wnm3 What was the reason this PR was closed? Any issue with the fix or additional changes needed? |
|
Hmm, I thought it has been accepted. I can reopen... |
|
I'm releasing v2.4.5 today -- will be in Maven in a few hours. Sorry for the confusion. |
|
Thanks for sorting it so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
Fix is based on the original JSONata fix, (jsonata-js/jsonata#644) basically just removed the extra = from === as the code is consistent between the JS and Java versions.
Updates $fromMillis() function to support am/pm PN presentation format to output AM/PM and adds test cases for PN and Pn (existing test case for default presentation covers just P).