Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 20 support #1355

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Add node 20 support #1355

merged 4 commits into from
Oct 18, 2023

Conversation

eiri
Copy link
Member

@eiri eiri commented Oct 17, 2023

PR summary

Officially adds node 20 support

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@eiri eiri requested a review from a team as a code owner October 17, 2023 12:52
@eiri
Copy link
Member Author

eiri commented Oct 17, 2023

So, apparently node 21 is expected to be released today, so let's wait some hours before attempting to add it again

@eiri eiri merged commit 587c0d7 into main Oct 18, 2023
5 checks passed
@eiri eiri deleted the s711-update-node-20 branch October 18, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants