Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Turbonomic folder to store new orm files #2277

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

yannizhang2019
Copy link
Member

@yannizhang2019 yannizhang2019 commented Oct 29, 2024

Copy link
Member

@bitscuit bitscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming folder to devops-turbonomic-v1alpha1 to match the apiVersion and to distinguish from the old existing turbonomic folder

@ibm-ci-bot ibm-ci-bot added size/L and removed size/XS labels Oct 31, 2024
@yannizhang2019 yannizhang2019 changed the title Add a new folder to store orm files Clean up Turbonomic folder to store new orm files Oct 31, 2024
Copy link
Member

@bitscuit bitscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, yannizhang2019

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 31a011b into scripts-dev Oct 31, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants