Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta api entry cherry-pick #2283

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

bitscuit
Copy link
Member

cherry-picked #2278

Copy link
Contributor

@YCShen1010 YCShen1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I have left some comments below, thanks

labels:
operator.ibm.com/opreq-control: 'true'
name: meta-api-deploy
namespace: {{ .OperatorNs }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace: {{ .OperatorNs }}
namespace: "{{ .CPFSNs }}"

Hi, would you mind replacing all {{ .OperatorNs }} with "{{ .CPFSNs }}" for all ibm-platformui-operator-v4.x
according to https://github.com/IBM/ibm-common-service-operator/pull/2279/files

labels:
operator.ibm.com/opreq-control: 'true'
name: meta-api-deploy
namespace: {{ .OperatorNs }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace: {{ .OperatorNs }}
namespace: "{{ .ServicesNs }}"

For the namespace of meta-api-deploy in only ibm-zen-operator under CPFS v3, it would use serviceNs
typo fix in: https://github.com/IBM/ibm-common-service-operator/pull/2282/files

Copy link
Contributor

@YCShen1010 YCShen1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YCShen1010,bitscuit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit c4d4c99 into IBM:release-sc2 Oct 31, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants