-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta api entry cherry-pick #2283
Conversation
Signed-off-by: Henry Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I have left some comments below, thanks
controllers/constant/odlm.go
Outdated
labels: | ||
operator.ibm.com/opreq-control: 'true' | ||
name: meta-api-deploy | ||
namespace: {{ .OperatorNs }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace: {{ .OperatorNs }} | |
namespace: "{{ .CPFSNs }}" |
Hi, would you mind replacing all {{ .OperatorNs }}
with "{{ .CPFSNs }}"
for all ibm-platformui-operator-v4.x
according to https://github.com/IBM/ibm-common-service-operator/pull/2279/files
controllers/constant/odlm.go
Outdated
labels: | ||
operator.ibm.com/opreq-control: 'true' | ||
name: meta-api-deploy | ||
namespace: {{ .OperatorNs }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace: {{ .OperatorNs }} | |
namespace: "{{ .ServicesNs }}" |
For the namespace of meta-api-deploy
in only ibm-zen-operator
under CPFS v3, it would use serviceNs
typo fix in: https://github.com/IBM/ibm-common-service-operator/pull/2282/files
Signed-off-by: Henry Li <[email protected]>
Signed-off-by: YuChen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitscuit, YCShen1010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cherry-picked #2278