Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added turbonomics orm for opensearch #2296

Open
wants to merge 4 commits into
base: scripts-dev
Choose a base branch
from

Conversation

PRTamilanban
Copy link

@PRTamilanban PRTamilanban commented Nov 8, 2024

What this PR does / why we need it:
It has ORM for opensearch component
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/64872

Special notes for your reviewer:

  1. How the test is done?
    Yes
    How to backport this PR to other branch:
  2. Add label to this PR with the target branch name backport <branch-name>
  3. The PR will be automatically created in the target branch after merging this PR
  4. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PRTamilanban
Once this PR has been reviewed and has the lgtm label, please assign qpdpq for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Tamilanban Rajendran <[email protected]>
kind: OperatorResourceMapping
metadata:
name: opensearch-orm
namespace: $namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace: $namespace
namespace: {{ placeholder_namespace }}

Please change the placeholder value

Copy link
Member

@bitscuit bitscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the operator ORM file. We will not support that until next release

@ibm-ci-bot ibm-ci-bot added size/S and removed size/M labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants