Refresh Recipe by removing setup tenant job #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YCShen1010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: YuChen <[email protected]>
YCShen1010
force-pushed
the
refresh-br
branch
from
89420d7 to
ac4a79c
Compare
Signed-off-by: YuChen <[email protected]>
Signed-off-by: YuChen <[email protected]>
|
It is ready to merge NSS restored successfully: |
YCShen1010
force-pushed
the
refresh-br
branch
from
8757218 to
f7da056
Compare
bluzarraga
reviewed
Dec 2, 2024
| CONTROL_NS="" # Pass the control namespace if it is needed to be backed up | ||
|
|
||
| #Pass any additional namespaces in the tenant that are not the operator or services namespace. Comma delimited | ||
| TETHERED_NS="" | ||
| TETHERED_NS="tenant1,tenant2" |
There was a problem hiding this comment.
Make sure to remove these test values before merging
There was a problem hiding this comment.
Oh, Good catch, thanks, Ben.
Signed-off-by: YuChen <[email protected]>
YCShen1010
force-pushed
the
refresh-br
branch
from
f7da056 to
2d7f330
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65357