Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the URL value in the ROKS URL field in the platform-auth-idp configmap #2326

Merged
merged 13 commits into from
Dec 18, 2024

Conversation

bluzarraga
Copy link
Member

@bluzarraga bluzarraga commented Dec 5, 2024

What this PR does / why we need it: This PR allows us to BR the platform-auth-idp configmap by updating the ROKS_URL field. This field previously would cause problems in ROKS environments because it would not be updated by the IM operator so if restoring to a new cluster, it would still point to the old cluster. Going forward IM will update this value automatically but for backwards compatibility, we need to be able to update this value to preserve any configurations made in the configmap

A couple things remaining:

  • check version so we do not perform these steps when IM can make this update itself
  • check the cs-onprem-tenant-config which should configure a custom domain name
    • Right now the accompanying onprem-tenant-config script is only run when following OADP instructions, can we include it in this script so it is run automatically and during spectrum fusion?
  • add the configmap to the labeling script

Update to the remaining items

  • created a second version of the script to be used for CS 4.11+ and 4.6.10+ as it is difficult to determine the version in use without adding more info on what the operator namespace is or significant permissions
  • We do not need to check for the cs-onprem-tenant-config cm because it does not affect the value we need

Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65249

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bluzarraga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
@ibm-ci-bot ibm-ci-bot added size/L and removed size/M labels Dec 5, 2024
@bluzarraga bluzarraga changed the title [WIP] Update the URL value in the ROKS URL field in the platform-auth-idp configmap Update the URL value in the ROKS URL field in the platform-auth-idp configmap Dec 5, 2024
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
@qpdpQ
Copy link
Contributor

qpdpQ commented Dec 18, 2024

test looks good to me:

...
[INFO] Creating dummy route to update ROKS_URL value...
route.route.openshift.io/dummy created
[INFO] Grabbing new hostname...
[INFO] New hostname: saml.cp.fyre.ibm.com
[INFO] New ROKS_URL value: https://oauth-openshift.apps.saml.cp.fyre.ibm.com
[INFO] Updating ROKS_URL value in platform-auth-idp configmap...
configmap/platform-auth-idp patched (no change)
[INFO] Deleting dummy route from namespace cpfs...
route.route.openshift.io "dummy" deleted
...

restore succeeded

@qpdpQ
Copy link
Contributor

qpdpQ commented Dec 18, 2024

/lgtm

@ibm-ci-bot ibm-ci-bot merged commit f9cf1ac into IBM:scripts-dev Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants