-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the URL value in the ROKS URL field in the platform-auth-idp configmap #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Luzarraga <[email protected]>
sync fork scripts-dev with actual
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bluzarraga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
bluzarraga
changed the title
[WIP] Update the URL value in the ROKS URL field in the platform-auth-idp configmap
Update the URL value in the ROKS URL field in the platform-auth-idp configmap
Dec 5, 2024
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
Signed-off-by: Ben Luzarraga <[email protected]>
test looks good to me:
restore succeeded |
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR allows us to BR the platform-auth-idp configmap by updating the ROKS_URL field. This field previously would cause problems in ROKS environments because it would not be updated by the IM operator so if restoring to a new cluster, it would still point to the old cluster. Going forward IM will update this value automatically but for backwards compatibility, we need to be able to update this value to preserve any configurations made in the configmap
A couple things remaining:
Update to the remaining items
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65249
Special notes for your reviewer:
How to backport this PR to other branch:
backport <branch-name>
backport <branch-name>
and leave a comment/backport
to trigger the backport action