-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suspend go routines until operator cache is ready #2327
Conversation
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
test logs
it takes about 7 seconds to wait
|
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
test looks good to me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Daniel-Fan, qpdpQ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 7cdb53c.
* Revert "suspend go routines until operator cache is ready (#2327)" This reverts commit 7cdb53c. * start go routines after cs controller manager setup Signed-off-by: Daniel Fan <[email protected]> --------- Signed-off-by: Daniel Fan <[email protected]>
What this PR does / why we need it:
Go routines in ibm-common-service operator relies on operator controller's cache to be ready. It will be ready when Manager is set up. So we need to suspend go routines until manager is setup
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/58246