-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create singleton recipe for Cert Manager #2328
base: scripts-dev
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YCShen1010 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
44db113
to
d298b6f
Compare
6abe20e
to
22759b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about how we want cert manager to work in these recipes during our sync up tomorrow. It sits in a weird spot since it is mandatory compared to the licensing singletons and I think that requires a little more discussion
velero/spectrum-fusion/cert-manager/backup-restore-workflow.yaml
Outdated
Show resolved
Hide resolved
ce5d3d5
to
b5e7bf6
Compare
Signed-off-by: YuChen <[email protected]>
Signed-off-by: YuChen <[email protected]>
Signed-off-by: YuChen <[email protected]>
Signed-off-by: YuChen <[email protected]>
cf6bdf0
to
3e964d6
Compare
recipe: | ||
apiVersion: spp-data-protection.isf.ibm.com/v1alpha1 | ||
name: cert-manager-recipe | ||
namespace: ibm-spectrum-fusion-ns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the backup-restore-workflow.yaml idea, good job
3e964d6
to
79c5997
Compare
Signed-off-by: YuChen <[email protected]>
What this PR does:
Create a new template for Cert Manager and resources cert manager configs including set of Application, Assignment, PolicyAssignment and new streamlined Recipe
Issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/64751
Condition check
Test steps:
Test result
Positive case:
Negative case (if there is a cert manager present in the restore cluster, then error out):