Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create singleton recipe for Cert Manager #2328

Open
wants to merge 5 commits into
base: scripts-dev
Choose a base branch
from

Conversation

YCShen1010
Copy link
Contributor

@YCShen1010 YCShen1010 commented Dec 6, 2024

What this PR does:

Create a new template for Cert Manager and resources cert manager configs including set of Application, Assignment, PolicyAssignment and new streamlined Recipe

Issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/64751

Condition check

  1. Before backup: if there is no IBM cert manager subscription, then it failed (checking by selectorlabel).
  2. Before restore: if there is already a cert manager webhook exists on the cluster, then failed and error out.

Test steps:

  1. Install IBM Cert Manager
  2. Create new cert manager templates
  3. Run backup and restore on fusion

Test result

Positive case:
Screenshot 2024-12-06 at 16 47 32

Negative case (if there is a cert manager present in the restore cluster, then error out):
Screenshot 2024-12-07 at 23 33 16

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@bluzarraga bluzarraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about how we want cert manager to work in these recipes during our sync up tomorrow. It sits in a weird spot since it is mandatory compared to the licensing singletons and I think that requires a little more discussion

@ibm-ci-bot ibm-ci-bot added size/XL and removed size/L labels Dec 11, 2024
@YCShen1010 YCShen1010 force-pushed the cm-recipe branch 2 times, most recently from ce5d3d5 to b5e7bf6 Compare December 12, 2024 03:48
@YCShen1010 YCShen1010 force-pushed the cm-recipe branch 2 times, most recently from cf6bdf0 to 3e964d6 Compare December 12, 2024 04:11
recipe:
apiVersion: spp-data-protection.isf.ibm.com/v1alpha1
name: cert-manager-recipe
namespace: ibm-spectrum-fusion-ns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the backup-restore-workflow.yaml idea, good job

@ibm-ci-bot ibm-ci-bot removed the size/L label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants