Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changes from scripts-dev to scripts-adopter #2330

Open
wants to merge 4 commits into
base: scripts-adopter
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 9, 2024

common service installer automation on 2024-12-09-20-10-32

* update nss resources br label

Signed-off-by: YuChen <[email protected]>

* remove setup tenant and restore nss for 4.7 multi recipes

Signed-off-by: YuChen <[email protected]>

* remove setup tenant job for 4.7 single recipe

Signed-off-by: YuChen <[email protected]>

* remove job and use nss for 4.5 recipes

Signed-off-by: YuChen <[email protected]>

---------

Signed-off-by: YuChen <[email protected]>
Copy link
Author

github-actions bot commented Dec 9, 2024

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign daniel-fan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot
Copy link
Collaborator

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a IBM member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

…onfigmap (#2326)

* add common-web-ui-config cm to labeling script

Signed-off-by: Ben Luzarraga <[email protected]>

* update roks url value

Signed-off-by: Ben Luzarraga <[email protected]>

* update permissions

Signed-off-by: Ben Luzarraga <[email protected]>

* add new version of script

Signed-off-by: Ben Luzarraga <[email protected]>

* change file name

Signed-off-by: Ben Luzarraga <[email protected]>

* add platform-auth-idp to labeling script

Signed-off-by: Ben Luzarraga <[email protected]>

* alter how route is applied

Signed-off-by: Ben Luzarraga <[email protected]>

* update permissions and file location

Signed-off-by: Ben Luzarraga <[email protected]>

* update typo

Signed-off-by: Ben Luzarraga <[email protected]>

* add 1 to cut len

Signed-off-by: Ben Luzarraga <[email protected]>

* edit patch command

Signed-off-by: Ben Luzarraga <[email protected]>

---------

Signed-off-by: Ben Luzarraga <[email protected]>
Copy link
Author

please add label ok-to-sync and remove label do-not-merge/hold to merge the PR

@ibm-ci-bot ibm-ci-bot added size/XL and removed size/L labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants