delete storageclass from cs cr #2334
Open
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Li <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qpdpQ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Daniel-Fan
reviewed
Dec 11, 2024
| ' | \ | ||
| $OC apply -n $TO_NAMESPACE -f - || error "Failed to copy over $resourceType $resourceName." | ||
|
|
||
| if [[ $resourceType == "commonservice" && $storageClass_exist == "true"]]; then |
There was a problem hiding this comment.
Hi @qpdpQ
I am wondering if this could be optimized to reduce the duplicated code?
For example, all the resources will have same steps for removing certain fields firstly, then an additional to remove .spec.storageClass if it is CommonService CR?
There was a problem hiding this comment.
Yeah, that's a good idea
Signed-off-by: Allen Li <[email protected]>
Signed-off-by: Allen Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
preload_data script should delete storageclass from cs cr
Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65562