Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistently check OIDC job readiness #2335

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

bluzarraga
Copy link
Member

What this PR does / why we need it: Its possible for the columns to be switched when trying to read job readiness. This can happen for pods as well. We need to check for either so we do not miss when it is not the one we expect in the column we expect it to be.

Seen when testing #2321

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bluzarraga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qpdpQ
Copy link
Contributor

qpdpQ commented Jan 7, 2025

/lgtm

@ibm-ci-bot ibm-ci-bot added the lgtm label Jan 7, 2025
@ibm-ci-bot ibm-ci-bot merged commit fb3a70d into IBM:scripts-dev Jan 7, 2025
5 checks passed
@qpdpQ
Copy link
Contributor

qpdpQ commented Jan 7, 2025

tested in #2321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants