Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#20 generate docker image #48

Merged
merged 54 commits into from
Dec 20, 2024
Merged

#20 generate docker image #48

merged 54 commits into from
Dec 20, 2024

Conversation

kkazmierczyk
Copy link
Collaborator

Fixes #20 .

This pull request creates a .Dockerfile plus updates the documentation.

I have created #47 to investigate creation of official package.

This pull request is created from 12-generate-pip-package branch.

@kkazmierczyk
Ref #12 changed dir structure
085cfa4 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Changed the project name to Javacore analyser
55981d3 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Added init.py file
e10fffa 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Reorganised imports
2ba7017 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Make create_xml_xsl_for_collection a static method
3c78be3 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Change tool name logging
e8086d8 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Moved comment to appropriate section
0c50214 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref 12 corrected creation of data files
953a068 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref 12 Moved templates dir
b0b1e96 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Corrected class names in javacore_analyser_web.py
0f7e73c 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Fixes #32 access files as resources
86ae780 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Merge remote-tracking branch 'origin/main' into 12-generate-pip-package
d82fa83
@kkazmierczyk
Ref #12 Created pyproject.toml
7207ee8 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Added dist dir to gitignore
2e7b4bb 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Corrected version
0611c82 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 working command line
59d06ed 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 removed unnecessary package find
a7ebae7 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Added egg-info to ignored
6708277 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Fix #12 Changed build system to hatchling
687f219 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Added topics
15c8a08 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Corrected imports in javacore_analyser_web.py
3ffb2ee 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Added Flask dependency
7936a16 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Corrected logging utils
60339d1 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Added PYTHONPATH to travis tests
d6c611c 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Added PYTHONPATH to travis tests
3083a41 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 corrected test name for javacore analyser
34c4f2b 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Added closing bracket to input files separator
c917741 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Option to start Waitress
39b89da 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Fixes uncotrolled data used in path expression
b5b1e34 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Added reports dir to .gitignore
f0d3c34 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #20 Generated docker image
95eabcb 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #20 Added creating dir in Dockerfile
2e01cf8 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #20 Added instrutctions how to run containers manually.
0be12f1 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #20 Updated documentation.
c007170 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk kkazmierczyk linked an issue Nov 25, 2024 that may be closed by this pull request
Generate docker image #20
Closed
PiotrAniola82 and others added 6 commits November 26, 2024 09:25
@PiotrAniola82
Fixed a bug where hardcoded Unix-style path separators were causing S…
5be3c5a 
…ecurityExceptions to be raised on Windows.

Signed-off-by: PiotrAniola82 <[email protected]>
@kkazmierczyk
Ref #12 Updated paths to use os.path.join method
4557e6e 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #12 Some formatting fixes
2d9881d 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Merge remote-tracking branch 'origin/main' into 12-generate-pip-package
a8073e4 
# Conflicts:
#	requirements.txt
#	src/javacore_analyser/javacore_set.py
@kkazmierczyk
Ref #2 Added tqdm library to pyproject.toml
08bd9b9 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Merge remote-tracking branch 'origin/12-generate-pip-package' into 20…
964906f 
…-generate-docker-image
@kkazmierczyk
Copy link
Collaborator Author

It is ready for review. @PiotrAniola82 @tjanasiewicz can you review it?
There are changes only in the following files:
Created Dockerfile
Added some documentation to Contributing.md and README.md

@kkazmierczyk kkazmierczyk marked this pull request as ready for review November 26, 2024 15:04
This was referenced Nov 30, 2024
Open
Closed
@PiotrAniola82
Copy link
Collaborator

Automated tests pass on this branch, however, I don't know how to perform functional tests. You wrote you added some documentation to Contributing.md and README.md, but I did not find any mention of Docker in either of these files.

@kkazmierczyk
Copy link
Collaborator Author

kkazmierczyk commented Dec 1, 2024 •
edited
Loading

Automated tests pass on this branch, however, I don't know how to perform functional tests. You wrote you added some documentation to Contributing.md and README.md, but I did not find any mention of Docker in either of these files.

@PiotrAniola82 Search for "container" word instead: "Build container localy" or "Running container image".
I used Podman in my examples, however Docker commands will be the same

@kkazmierczyk
Ref #48 added command to run in docker
346ef6a 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk
Ref #48 changed or to lowercase
0fdedfe 
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
@kkazmierczyk kkazmierczyk changed the title 20 generate docker image #20 generate docker image Dec 3, 2024
@kkazmierczyk kkazmierczyk mentioned this pull request Dec 16, 2024
Merged
kkazmierczyk
kkazmierczyk commented Dec 20, 2024
View reviewed changes
Copy link
Collaborator Author

@kkazmierczyk kkazmierczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@tjanasiewicz tjanasiewicz merged commit 42881a1 into main Dec 20, 2024
6 checks passed
@tjanasiewicz tjanasiewicz deleted the 20-generate-docker-image branch December 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjanasiewicz tjanasiewicz Awaiting requested review from tjanasiewicz

@PiotrAniola82 PiotrAniola82 Awaiting requested review from PiotrAniola82

Assignees

@tjanasiewicz tjanasiewicz

Labels
current sprint (10.12) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate docker image
3 participants
@kkazmierczyk @PiotrAniola82 @tjanasiewicz