fix: various fixes for non-minio s3 endpoints #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
starpit
commented
Nov 11, 2024
starpit
commented
- improved detection of errors from ibmcloud
- boot/up had assumed that the minio component would disappear as part of its cleanup logic
- clean up boot/alldone to call the simpler WaitTillExists() API
- a few other bug fixes in the way the polling varying of Listen() API worked; e.g. we weren't properly avoiding re-notifying on existing objects when polling
starpit
force-pushed
the
non-minio-fixes
branch
4 times, most recently
from
cef3812
to
c3f1c0b
Compare
- improved detection of errors from ibmcloud - boot/up had assumed that the minio component would disappear as part of its cleanup logic - clean up boot/alldone to call the simpler WaitTillExists() API - a few other bug fixes in the way the polling varying of Listen() API worked; e.g. we weren't properly avoiding re-notifying on existing objects when polling Signed-off-by: Nick Mitchell <[email protected]>
starpit
force-pushed
the
non-minio-fixes
branch
from
c3f1c0b
to
2d5e7a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.