Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track logical paths in recursive validation functions #709

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hudlow
Copy link
Member

@hudlow hudlow commented Dec 23, 2024

PR summary

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline has been updated as needed
  • npm run generate-utilities-docs has been run if any files in packages/utilities/src have been updated

@hudlow
Copy link
Member Author

hudlow commented Dec 23, 2024

Still missing explicit tests for:

  • the SchemaPath class
  • this guarantee of validateSubschemas():
    The provided `validate()` function is guaranteed to be called:
    - for a schema before any of its composed schemas
    - for a schema before any of its nested schemas
    

@hudlow hudlow force-pushed the hudlow/logical-paths branch from d839ac9 to 4b724cd Compare December 23, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant