Custom modules

[Joao-L-S-Almeida]

This is a prototype of how we could combine two model pipelines in terratorch. I believe it could be the easiest way to include third-party and custom model in our tests.

[romeokienzler]

this comment is in the wrong place?

[Joao-L-S-Almeida]

Yep.

[romeokienzler]

What happens if model is not passed as parameter? it is none, correct? does it have any implications?

[Joao-L-S-Almeida]

I just modified it to guarantee that or a model_factory or a model is provided:

  if model_factory:  
         self.model_factory = MODEL_FACTORY_REGISTRY.build(model_factory)
         self.model_builder = self._build
 elif model:
     self.model_builder = self._bypass_build
 else:
     raise Exception("Or a model_factory or a torch.nn.Module object must be provided.")

Which will allow the selection of the most proper builder method.

[romeokienzler]

So are you sure this works?

Case 1:
You pass a modelfactory, then self.model_builder = self._build and the model is build from the factory

Case 2:
You don't pass a model factory but a model
self.model_builder = self._bypass_build and the one you get passed in from constructor is used

I think the code is correct but hard to understand, I also might wanna add some argument checking, e.g. if model factory is None a model need to be passed

[Joao-L-S-Almeida]

When no model_factory is passed, it used the object model, so the the method self._bypass_build just return this already instantiated object to be used during the process.