-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds TokenizationTaskRequest and InfoService #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviabeo
changed the title
Adds new caikit NLP and Info APIs
Adds TokenizationTaskRequest and InfoService
Jul 30, 2024
flaviabeo
force-pushed
the
caikit-apis
branch
5 times, most recently
from
August 1, 2024 16:51
29c0110
to
e384d35
Compare
This includes the TokenizationTaskRequest method for the embeddings models at the NLP interface + implements the InfoService for the watsonx product team requirement to be able to retrieve embeddings models' metadata. - Implements tokenization_task_predict method for NlpServicer - Implements InfoServicer with get_models_info method Signed-off-by: Flavia Beo <[email protected]>
joerunde
reviewed
Aug 2, 2024
joerunde
reviewed
Aug 2, 2024
joerunde
reviewed
Aug 2, 2024
Signed-off-by: Flavia Beo <[email protected]>
joerunde
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the back and forth, would it be better if we hop on a slack huddle about this?
Signed-off-by: Flavia Beo <[email protected]>
joerunde
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the
TokenizationTaskRequest
method for the embeddings models at theNLP
interface + implements theInfoService
for the watsonx product team requirement to be able to retrieve embeddings models' metadata.