Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TokenizationTaskRequest and InfoService #11

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

flaviabeo
Copy link
Contributor

@flaviabeo flaviabeo commented Jul 30, 2024

This includes the TokenizationTaskRequest method for the embeddings models at the NLP interface + implements the InfoService for the watsonx product team requirement to be able to retrieve embeddings models' metadata.

  • Implements tokenization_task_predict method for NlpServicer;
  • Implements InfoServicer with get_models_info method;

@flaviabeo flaviabeo changed the title Adds new caikit NLP and Info APIs Adds TokenizationTaskRequest and InfoService Jul 30, 2024
@flaviabeo flaviabeo force-pushed the caikit-apis branch 5 times, most recently from 29c0110 to e384d35 Compare August 1, 2024 16:51
This includes the TokenizationTaskRequest method for the embeddings models at the NLP interface + implements the InfoService for the watsonx product team requirement to be able to retrieve embeddings models' metadata.

- Implements tokenization_task_predict method for NlpServicer
- Implements InfoServicer with get_models_info  method

Signed-off-by: Flavia Beo <[email protected]>
Signed-off-by: Flavia Beo <[email protected]>
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the back and forth, would it be better if we hop on a slack huddle about this?

Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joerunde joerunde merged commit 87b9dfd into IBM:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants